linux-kernel - [PATCH][RFC] input: remove bios I8042_CTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 27 Oct 2009 13:34:04 +0800
From:	Dave Young <hidave.darkstar@...il.com>
To:	dmitry.torokhov@...il.com
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH][RFC] input: remove bios I8042_CTR_XLATE check to make
	keyboard usable


Pressing somekey at early booting phase cause keyboard to be not usable
(The hardware is DELL latitude e5400):

atkbd.c: Unknown key pressed (raw set 2, code 0xd3 on isa0060/serio0).
atkbd.c: Use 'setkeycodes e053 <keycode>' to make it known.
atkbd.c: Unknown key pressed (raw set 2, code 0x1d3 on isa0060/serio0).
atkbd.c: Use 'setkeycodes e053 <keycode>' to make it known.

i8042.c set i8042_direct to true when the controller init. But the result
is keyboard not usable, The only option is press the power button to shutdown. 

So here remove the bios check to fix it.

Signed-off-by: Dave Young <hidave.darkstar@...il.com>
---
 drivers/input/serio/i8042.c |    8 --------
 1 file changed, 8 deletions(-)

--- linux-2.6.orig/drivers/input/serio/i8042.c	2009-10-13 08:57:07.000000000 +0800
+++ linux-2.6/drivers/input/serio/i8042.c	2009-10-27 13:15:13.000000000 +0800
@@ -869,14 +869,6 @@ static int i8042_controller_init(void)
 	spin_unlock_irqrestore(&i8042_lock, flags);
 
 /*
- * If the chip is configured into nontranslated mode by the BIOS, don't
- * bother enabling translating and be happy.
- */
-
-	if (~i8042_ctr & I8042_CTR_XLATE)
-		i8042_direct = true;
-
-/*
  * Set nontranslated mode for the kbd interface if requested by an option.
  * After this the kbd interface becomes a simple serial in/out, like the aux
  * interface is. We don't do this by default, since it can confuse notebook
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/