lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 28 Oct 2009 08:25:41 +0100 From: Mike Galbraith <efault@....de> To: Peter Zijlstra <peterz@...radead.org> Cc: Arjan van de Ven <arjan@...radead.org>, mingo@...e.hu, linux-kernel@...r.kernel.org Subject: Re: [PATCH 3/3] sched: Disable affine wakeups by default On Tue, 2009-10-27 at 15:35 +0100, Mike Galbraith wrote: > On Mon, 2009-10-26 at 02:53 +0100, Peter Zijlstra wrote: > > On Sun, 2009-10-25 at 23:04 +0100, Mike Galbraith wrote: > > > if (want_affine && (tmp->flags & SD_WAKE_AFFINE) && > > > - cpumask_test_cpu(prev_cpu, sched_domain_span(tmp))) { > > > + (level == SD_LV_SIBLING || level == SD_LV_MC)) { > > > > quick comment without actually having looked at the patch, we should > > really get rid of sd->level and encode properties of the sched domains > > in sd->flags. > > I used SD_PREFER_SIBLING in the below. Did I break anything? Um, other than taskset. > + if (candidate == -1 || candidate == cpu) { > + for_each_cpu(i, sched_domain_span(tmp)) { if (!cpumask_test_cpu(i, &p->cpus_allowed)) continue; (i think i'm going to need that domain flag in a few minutes anyway) -Mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists