linux-kernel - Re: [tip:perf/core] tracing/filters: Refactor subsystem filter code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4AE80993.5000300@cn.fujitsu.com>
Date:	Wed, 28 Oct 2009 17:06:27 +0800
From:	Li Zefan <lizf@...fujitsu.com>
To:	Ingo Molnar <mingo@...e.hu>
CC:	linux-tip-commits@...r.kernel.org, linux-kernel@...r.kernel.org,
	hpa@...or.com, mingo@...hat.com, tzanussi@...il.com,
	peterz@...radead.org, fweisbec@...il.com, rostedt@...dmis.org,
	tglx@...utronix.de
Subject: Re: [tip:perf/core] tracing/filters: Refactor subsystem filter code

Ingo Molnar wrote:
> * tip-bot for Li Zefan <lizf@...fujitsu.com> wrote:
> 
>> Commit-ID:  fce29d15b59245597f7f320db4a9f2be0f5fb512
>> Gitweb:     http://git.kernel.org/tip/fce29d15b59245597f7f320db4a9f2be0f5fb512
>> Author:     Li Zefan <lizf@...fujitsu.com>
>> AuthorDate: Thu, 15 Oct 2009 11:20:34 +0800
>> Committer:  Ingo Molnar <mingo@...e.hu>
>> CommitDate: Thu, 15 Oct 2009 11:35:22 +0200
> 
> the filter variable was not initialized here - i have applied the fix 
> below.
> 

I sent out the patchset and then went for a travel, and came back
to found this fixup is wrong..

I'll send out the correct fix soon.

> 	Ingo
> 
> Index: linux/kernel/trace/trace_events_filter.c
> ===================================================================
> --- linux.orig/kernel/trace/trace_events_filter.c
> +++ linux/kernel/trace/trace_events_filter.c
> @@ -1230,8 +1230,8 @@ static int replace_system_preds(struct e
>  				struct filter_parse_state *ps,
>  				char *filter_string)
>  {
> +	struct event_filter *filter = system->filter;
>  	struct ftrace_event_call *call;
> -	struct event_filter *filter;
>  	int err;
>  	bool fail = true;
>  
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/