[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20091028.051631.212225494.davem@davemloft.net>
Date: Wed, 28 Oct 2009 05:16:31 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: arndbergmann@...glemail.com
Cc: airlied@...ux.ie, dri-devel@...ts.sourceforge.net,
andi@...stfloor.org, linux-kernel@...r.kernel.org
Subject: Re: is avoiding compat ioctls possible?
From: Arnd Bergmann <arndbergmann@...glemail.com>
Date: Wed, 28 Oct 2009 13:13:32 +0100
> The ioctl argument actually needs a compat_ptr() conversion as well.
> For the s390 case, we can't do that in common code, because some
> ioctl methods put a 32 bit integer into the argument. Not sure if we
> want to fix that everywhere, the problem is very common and the
> impact is minimal.
What does s390 do with the 'arg' argument to sys_ioctl()?
That assumption that you can cast this to a pointer is everywhere.
If someone wants to fix this up, feel free to do an audit and go
over that seperately from my work :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists