linux-kernel - Re: [patch] Re: Zillions of warnings in -next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4AE848BC.6020202@novell.com>
Date:	Wed, 28 Oct 2009 09:35:56 -0400
From:	Gregory Haskins <ghaskins@...ell.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>
CC:	Alan Cox <alan@...rguk.ukuu.org.uk>, linux-kernel@...r.kernel.org
Subject: Re: [patch] Re: Zillions of warnings in -next

Randy Dunlap wrote:
> On Tue, 27 Oct 2009 22:21:12 +0000 Alan Cox wrote:
> 
>>> I just did a 32-bit build and indeed reproduced the warnings.  However, the warnings
>>> appear to be dubious as the code is properly (afaict) annotated with explicit casts, and
>>> I believe they are doing what I intended.
>>>
>>> Basically I have structures that are always 64 bit (so we can have a mixed-mode 32-bit
>>> guest talk to a 64-bit hypervisor, for instance).  Therefore I am casting between native
>>> and u64, but the compiler doesn't like this.  Does anyone have any suggestions on ways
>>> to fix this so the compiler is happy?
>> 	foo = (void *)(unsigned long)x
>>
>> works for the general case because Linux assumes ptr fits ulong
>>
>> Similarly in the other direction.

Thank you, Alan.  Your tip was spot on.

> 
> Yes, I already had this done for venet and pci-bridge.  Patch below.
> 
> ---
> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> Eliminate all cast warnings in vbus-enet.c and pci-bridge.c.
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>

Thank you, Randy.  Applied.

Kind Regards,
-Greg



Download attachment "signature.asc" of type "application/pgp-signature" (268 bytes)