lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 28 Oct 2009 16:03:04 +0100 From: Tejun Heo <tj@...nel.org> To: "Luck, Tony" <tony.luck@...el.com> CC: Randy Dunlap <randy.dunlap@...cle.com>, Stephen Rothwell <sfr@...b.auug.org.au>, Jes Sorensen <jes@....com>, "linux-ia64@...r.kernel.org" <linux-ia64@...r.kernel.org>, "linux-next@...r.kernel.org" <linux-next@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, akpm <akpm@...ux-foundation.org> Subject: Re: [PATCH -next] ia64/sn: fix percpu warnings Hello, Luck, Tony wrote: >> WARNING: "per_cpu____sn_cnodeid_to_nasid" [drivers/misc/sgi-xp/xpc.ko] has no CRC! > > Note that this warning goes away if I fix the mismatch declaration so > that we have: > > DECLARE_PER_CPU(short, __sn_cnodeide_to_nasid[MAX_COMPACT_NODES]); > in arch.h > > and > > DEFINE_PER_CPU(short, __sn_cnodeide_to_nasid[MAX_COMPACT_NODES]); > in setup.c Umm... the correct correct declaration and definition would be DECLARE_PER_CPU(short [MAX_COMPACT_NODES], __sn_cnodeide_to_nasid); and DEFINE_PER_CPU(short [MAX_COMPACT_NODES], __sn_cnodeide_to_nasid); So that the first part contains full type. Doing it the other way might cause problems if the __weak trick is turned on. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists