linux-kernel - Re: is avoiding compat ioctls possible?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87hbtkjkki.fsf@basil.nowhere.org>
Date:	Wed, 28 Oct 2009 03:53:17 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Dave Airlie <airlied@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	DRI Development Mailing List 
	<dri-devel@...ts.sourceforge.net>, Arnd Bergmann <arnd@...db.de>,
	David Miller <davem@...emloft.net>
Subject: Re: is avoiding compat ioctls possible?

Dave Airlie <airlied@...il.com> writes:

> They used uint64_t to represent userspace pointers and userspace
> casted into those and the kernel casts back out and passes it to copy_*_user

uint64_t is actually dangerous due to different alignment on x86-32 vs 64,
better use compat_u64/s64

> Now I thought cool I don't need to worry about compat ioctl hackery I can
> run 32 on 64 bit apps fine and it'll all just work.
>
> Now Dave Miller points out that I'm obivously deluded and we really need
> to add compat ioctls so that the kernel can truncate correctly 32-bit address
> in case userspace shoves garbage into the top 32bits of the u64.

When the user space sees a u64 field it should never shove garbage here.
You just have to cast on 32bit for this, which is a bit ugly.

However some architectures need special operations on compat pointers
(s390 iirc), but if you don't support those it might be reasonable
to not support that.

> Is there really no way to avoid compat ioctls? was I delusional in
> thinking there was?

Experience shows that people make mistakes and you sooner or
later need them anyways to work around them.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/