linux-kernel - Re: [tip:perf/core] perf tools, Alpha: Add Alpha support to perf.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 28 Oct 2009 21:58:44 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Pekka Enberg <penberg@...helsinki.fi>, mingo@...hat.com,
	hpa@...or.com, paulus@...ba.org, linux-kernel@...r.kernel.org,
	a.p.zijlstra@...llo.nl, ink@...assic.park.msu.ru,
	tglx@...utronix.de, rth@...ddle.net, mcree@...on.net.nz,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:perf/core] perf tools, Alpha: Add Alpha support to perf.h

> > 
> > OK, I'll bite. We tell userspace developers not to include kernel 
> > headers. Why is it okay for perf to do it (especially for something 
> > that's in asm)?
> 
> The main counter-argument against inclusion was always "what if we break 
> them accidentally". I.e. it can become a semi-ABI - stuff we cannot 
> change because we cannot change the outside projects. With perf this 
> cannot occur - it's all in one Git tree and can always be fixed/changed.
> 
> Note that we reuse a couple of other facilities in tools/perf as well - 
> linux/list.h, rbtree.c, etc. - and this is good - you can code perf as 
> if you were hacking on the kernel! ;-)

I see no reasons why perf should not use the exported headers
in the default case. unistd.h from alpha is indeed exported.

If perf then on top of that uses some kernel internal
stuff - then pick it up there.
But having perf in the kernel is not an excuse for avoinding
the exported headers.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/