linux-kernel - Re: is avoiding compat ioctls possible?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.0910280539150.19088@skynet.skynet.ie>
Date:	Wed, 28 Oct 2009 05:42:27 +0000 (GMT)
From:	Dave Airlie <airlied@...ux.ie>
To:	David Miller <davem@...emloft.net>
cc:	dri-devel@...ts.sourceforge.net, andi@...stfloor.org,
	linux-kernel@...r.kernel.org, arnd@...db.de
Subject: Re: is avoiding compat ioctls possible?


> Please don't do this.
> 
> This is exactly what I feared people would do when is_compat_task()
> was added.  is_compat_task() is for situations where there is
> otherwise no other way to handle the compat situation properly.
> 
> It's not that much work for you to hook up the compat ioctls properly,
> and if you are clever you can do it in such a way that you'll get
> warnings if someone accidently adds a new ioctl but forgets the
> compat bits :-)

There are close to 15 ioctls needing this, so I can add 15 functions to 
unpack and repack stuff or I can add that function, sorry if I'm 
leaning towards a lighter weight solution. I'll add this to my TODO for 
before the next merge window as its definitely more than I can manage now.

Dave.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/