linux-kernel - Re: [PATCH -next] k8.h: add struct bootnode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.0910290229490.21298@chino.kir.corp.google.com>
Date:	Thu, 29 Oct 2009 02:31:23 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>, Ingo Molnar <mingo@...e.hu>
cc:	Stephen Rothwell <sfr@...b.auug.org.au>, x86@...nel.org,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] k8.h: add struct bootnode

On Wed, 28 Oct 2009, Randy Dunlap wrote:

> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> k8.h uses struct bootnode but does not #include a header file
> for it, so provide a simple declaration for it.
> 
> arch/x86/include/asm/k8.h:13: warning: 'struct bootnode' declared inside parameter list
> arch/x86/include/asm/k8.h:13: warning: its scope is only this definition or declaration, which is probably not what you want
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>

Acked-by: David Rientjes <rientjes@...gle.com>

This is probably my fault originating from my patchset in Ingo's x86/mm 
tree with some unexpected config option combination.  Thanks Randy!

> ---
>  arch/x86/include/asm/k8.h |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20091028.orig/arch/x86/include/asm/k8.h
> +++ linux-next-20091028/arch/x86/include/asm/k8.h
> @@ -4,6 +4,7 @@
>  #include <linux/pci.h>
>  
>  extern struct pci_device_id k8_nb_ids[];
> +struct bootnode;
>  
>  extern int early_is_k8_nb(u32 value);
>  extern struct pci_dev **k8_northbridges;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/