linux-kernel - Re: [PATCH] firmware_class: make request_firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1256824692.5768.41.camel@localhost.localdomain>
Date:	Thu, 29 Oct 2009 22:58:12 +0900
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	Greg KH <gregkh@...e.de>,
	linux-wireless <linux-wireless@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Ming Lei <tom.leiming@...il.com>,
	Catalin Marinas <catalin.marinas@....com>,
	David Woodhouse <David.Woodhouse@...el.com>,
	Pavel Roskin <proski@....org>,
	Abhay Salunke <abhay_salunke@...l.com>
Subject: Re: [PATCH] firmware_class: make request_firmware_nowait more
 useful

Hi Johannes,

> Unfortunately, one cannot hold on to the struct firmware
> that request_firmware_nowait() hands off, which is needed
> in some cases. Allow this by requiring the callback to
> free it (via release_firmware).
> 
> Additionally, give it a gfp_t parameter -- all the current
> users call it from a GFP_KERNEL context so the GFP_ATOMIC
> isn't necessary. This also marks an API break which is
> useful in a sense, although that is obviously not the
> primary purpose of this change.
> 
> Signed-off-by: Johannes Berg <johannes@...solutions.net>

I had a look at this one and looks good to me and makes perfect sense.

Acked-by: Marcel Holtmann <marcel@...tmann.org>

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/