linux-kernel - Re: [Bug #14467] Linker errors on ia64 with NR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AE9AB23.8010207@kernel.org>
Date:	Thu, 29 Oct 2009 15:48:03 +0100
From:	Tejun Heo <tj@...nel.org>
To:	Christoph Lameter <cl@...ux-foundation.org>
CC:	Jiri Kosina <jkosina@...e.cz>, "Rafael J. Wysocki" <rjw@...k.pl>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Kernel Testers List <kernel-testers@...r.kernel.org>,
	Ingo Molnar <mingo@...e.hu>, Jeff Mahoney <jeffm@...e.com>,
	"Luck, Tony" <tony.luck@...el.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Peter Zijlstra <peterz@...radead.org>
Subject: Re: [Bug #14467] Linker errors on ia64 with NR_CPUS=4096

Christoph Lameter wrote:
>> There already are two patches for this acked by Ingo/Tejun, which Tejun is
>> going to take through his tree tomorrow.
>>
>> 	http://lkml.org/lkml/2009/10/27/132
> 
> per cpu alloc from an atomic context without passing gfp flags through to
> the page allocator? That does not look right. Sure wish that the percpu
> allocator would be working from atomic contexts for other cases.

It's just for sched_init() which has irq off but is not really in
atomic context and does GFP_KERNEL allocations.  The following comment
has been added to the first patch to explain it.

+ * allocations are done using GFP_KERNEL with pcpu_lock released.  In
+ * general, percpu memory can't be allocated with irq off but
+ * irqsave/restore are still used in alloc path so that it can be used
+ * from early init path - sched_init() specifically.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/