lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 29 Oct 2009 16:59:02 +0100 From: Tejun Heo <teheo@...e.de> To: Matthew Wilcox <matthew@....cx> Cc: Greg Kroah-Hartman <gregkh@...e.de>, linux-kernel@...r.kernel.org, Jesse Barnes <jbarnes@...tuousgeek.org>, linux-pci@...r.kernel.org Subject: Re: [PATCH 1/3] Fix updating of named attribute groups Matthew Wilcox wrote: > + if (update) { > + sd = sysfs_get_dirent(kobj->sd, grp->name); > + if (!sd) > + return -ENOENT; > + } else { > + error = sysfs_create_subdir(kobj, grp->name, &sd); > + if (error) > + return error; > + sysfs_get(sd); > + } > + } else { > + sd = sysfs_get(kobj->sd); > + } nitpick: the last braces aren't necessary. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists