linux-kernel - Re: [patch 1/3] x86, cpa: fix kernel text RO checks in static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1256781932.26028.2136.camel@gandalf.stny.rr.com>
Date:	Wed, 28 Oct 2009 22:05:32 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Suresh Siddha <suresh.b.siddha@...el.com>
Cc:	mingo@...e.hu, hpa@...or.com, linux-kernel@...r.kernel.org
Subject: Re: [patch 1/3] x86, cpa: fix kernel text RO checks in
 static_protection()

On Wed, 2009-10-28 at 18:46 -0800, Suresh Siddha wrote:
> plain text document attachment (fix_cpa_check.patch)
> Steven Rostedt reported that we are unconditionally making the
> kernel text mapping as read-only. i.e., if someone does cpa() to the
> kernel text area for setting/clearing any page table attribute, we
> unconditionally clear the read-write attribute for the kernel text mapping
> that is set at compile time.
> 
> We should delay (to forbid the write attribute) and enforce only after the
> kernel has mapped the text as read-only.
> 
> Reported-by: Steven Rostedt <rostedt@...dmis.org>
> Signed-off-by: Suresh Siddha <suresh.b.siddha@...el.com>

Heh, I wrote an almost identical patch myself. It would have been exact,
but I did not make the comment change ;-)

Acked-by: Steven Rostedt <rostedt@...dmis.org>

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/