linux-kernel - Re: [PATCH] [RFC][Patch x86-tip] add notifier before kdump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m11vkm11ne.fsf@fess.ebiederm.org>
Date:	Thu, 29 Oct 2009 11:43:49 -0700
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Jin Dongming <jin.dongming@...css.fujitsu.com>
Cc:	Vivek Goyal <vgoyal@...hat.com>,
	LKLM <linux-kernel@...r.kernel.org>,
	Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>,
	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>,
	Lon Hohberger <lhh@...hat.com>,
	Neil Horman <nhorman@...hat.com>
Subject: Re: [PATCH] [RFC][Patch x86-tip] add notifier before kdump

Jin Dongming <jin.dongming@...css.fujitsu.com> writes:

> Hi Vivek
>
> Vivek Goyal wrote:
>> - Other thing, I think Eric Biederman suggested was that we need to see
>>   the code that will be executed after crash so that it can be audited and
>>   keep it in kernel instead of blindly exporting a hook to module and let
>>   module do whatever it want to do.
>> 
>
> I am sorry for that I could not catch the meaning of above words. In my
> understanding:
>     If the code is already in current kernel and no matter whether it is built
>     or modulized, the code could be added before crash_kexec. Is it right?

No.  crash_kexec skips the calling the notifiers intentionally to increase
it's robustness.

> If my understanding is not right, please let me ask a question before we
> provide the code.
>     What kind of code is considered as nice code and could be added into
>     current kernel? Could you give me some requirements or examples
>     about nice code?

In general code that is necessary.  If we can find a way to avoid running
code in a broken kernel we should.

The recent addition of code to disable processor vitalization features
on a crash is an example of code that is necessary.  A small function
that we can always call that is not provided by a module.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/