linux-kernel - Re: is avoiding compat ioctls possible?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091028.224157.92041844.davem@davemloft.net>
Date:	Wed, 28 Oct 2009 22:41:57 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	arndbergmann@...glemail.com
Cc:	airlied@...ux.ie, dri-devel@...ts.sourceforge.net,
	andi@...stfloor.org, linux-kernel@...r.kernel.org,
	schwidefsky@...ibm.com, heiko.carstens@...ibm.com
Subject: Re: is avoiding compat ioctls possible?

From: Arnd Bergmann <arndbergmann@...glemail.com>
Date: Wed, 28 Oct 2009 16:40:18 +0100

> I'm pretty sure it was ok when we started adding the compat_ioctl
> handlers years ago. I think most people just ignored these for
> the majority of drivers that can't possibly run on s390. Even
> on s390, gcc will always do the right thing if you call call ioctl
> with a pointer to a normal object in the .data section, heap or stack,
> but hand-written assembly or other compilers may not.

Arnd, even compat_sys_ioctl() itself has constructs like:

	case FS_IOC_RESVSP:
	case FS_IOC_RESVSP64:
		error = ioctl_preallocate(filp, (void __user *)arg);
		goto out_fput;

That's why I asked about the 'arg' argument to sys_ioctl
on s390 :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/