linux-kernel - Re: [PATCH v4 1/7] m68knommu: Don't hardcode the value of PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AEA7352.4050202@snapgear.com>
Date:	Fri, 30 Oct 2009 15:02:10 +1000
From:	Greg Ungerer <gerg@...pgear.com>
To:	Tim Abbott <tabbott@...lice.com>
CC:	linux-kernel@...r.kernel.org, Sam Ravnborg <sam@...nborg.org>
Subject: Re: [PATCH v4 1/7] m68knommu: Don't hardcode the value of PAGE_SIZE
 in the linker script.

Hi Tim,

Tim Abbott wrote:
> On Fri, 30 Oct 2009, Greg Ungerer wrote:
> 
>> Hi Tim,
>>
>> This one gives me:
>>
>> arch/m68knommu/kernel/vmlinux.lds.S:19:1: warning: "BSS" redefined
>> In file included from arch/m68knommu/kernel/vmlinux.lds.S:10:
>> include/asm-generic/vmlinux.lds.h:495:1: warning: this is the location of the
>> previous definition
>>
>> A define named "BSS" is already used inside of vmlinux.lds.S.
>> No big deal, I just changed that internal one.
>>
>> But otherwise no problems with this patch.
> 
> This actually wasn't introduced by this patch -- it was introduced when 
> the BSS macro was merged into include/asm-generic/vmlinux.lds.h in commit 
> ef53dae8658cf0e93d380983824a661067948d87.
> 
> Regardless, changing the internal one was the right fix.

Indeed. Yep. I'll commit a fix for this first.

Regards
Greg


------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@...pgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/