linux-kernel - Re: F_SETOWN_EX and F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091030161320.17d07dc9.sfr@canb.auug.org.au>
Date:	Fri, 30 Oct 2009 16:13:20 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:	"Joseph S. Myers" <joseph@...esourcery.com>,
	linux-api@...r.kernel.org, lkml <linux-kernel@...r.kernel.org>,
	Oleg Nesterov <onestero@...hat.com>,
	Stephane Eranian <eranian@...glemail.com>,
	Michael Kerrisk <mtk.manpages@...glemail.com>,
	Roland McGrath <roland@...hat.com>,
	Al Viro <viro@...IV.linux.org.uk>,
	Christoph Hellwig <hch@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: F_SETOWN_EX and F_GETLK64 conflict

Hi Peter,

On Sun, 04 Oct 2009 23:30:22 +0200 Peter Zijlstra <a.p.zijlstra@...llo.nl> wrote:
>
> On Sun, 2009-10-04 at 12:35 +0000, Joseph S. Myers wrote:
> > In asm-generic/fcntl.h, F_SETOWN_EX and F_GETLK64 both have value 12, and 
> > F_GETOWN_EX and F_SETLK64 both have value 13.  I don't see how this is 
> > going to work correctly.  See 
> > <http://sourceware.org/ml/libc-ports/2009-10/msg00013.html>.
> 
> 
> Ugh,.. yeah, non obvious collision that.

This is why we have F_LINUX_SPECIFIC_BASE and use it in
include/linux/fcntl.h ... it should be used as a base for any new fcntl
types since they don't require backward compatibility.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped