linux-kernel - perf-record & perf-report in root directory: can't find binaries for symbol resolution

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <4AEC2601.8030803@tuffmail.co.uk>
Date:	Sat, 31 Oct 2009 11:56:49 +0000
From:	Alan Jenkins <alan-jenkins@...fmail.co.uk>
To:	Ingo Molnar <mingo@...e.hu>
CC:	linux-kernel <linux-kernel@...r.kernel.org>
Subject: perf-record & perf-report in root directory: can't find binaries
 for symbol resolution

Hi,

When I ran perf record & report in the root directory, I noticed that
perf couldn't find any binaries.  Both addresses and the actual names of
the binaries were printed as raw hex values:

# Overhead          Command  Shared Object  Symbol
# ........  ...............  .............  ......
#
    14.23%         modprobe       b777ce85  [.] 0x000000b777ce85
                |
                |--9.52%-- 0x804cad2
                |          0x8049b32


Strace showed that perf report was trying to open ".sbin/modprobe".  I
found a one-line fix, which should at least explain my problem:

---------------------------------------------
>From a2eb15237fee2276fc8e388f9e15409ed7caf9e1 Mon Sep 17 00:00:00 2001
From: Alan Jenkins <alan-jenkins@...fmail.co.uk>
Date: Fri, 30 Oct 2009 14:12:30 +0000
Subject: [PATCH] perf tools: fix test for whether pathnames can be shortened

The intention is to consider the pair (filename, cwd) and shorten the
filename if it lives under cwd.  E.g. ("/src/foo", "/src") -> "./foo".

Make the test more specific to exclude these unintended consequences:

    ("/src/foo", "/") -> ".src/foo"
    ("/src/foo", "/s") -> ".rc/foo"

Signed-off-by: Alan Jenkins <alan-jenkins@...fmail.co.uk>
---
 tools/perf/util/map.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/util/map.c b/tools/perf/util/map.c
index 804e023..bd17703 100644
--- a/tools/perf/util/map.c
+++ b/tools/perf/util/map.c
@@ -31,7 +31,7 @@ static int strcommon(const char *pathname, char *cwd, int cwdlen)
 		if (cwd) {
 			int n = strcommon(filename, cwd, cwdlen);
 
-			if (n == cwdlen) {
+			if (n == cwdlen && filename[n] == '/') {
 				snprintf(newfilename, sizeof(newfilename),
 					 ".%s", filename + n);
 				filename = newfilename;
-- 
1.6.3.2



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/