linux-kernel - Re: [RFC 2/2] Use unified UUID/GUID definition in gfs2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091101093545.a7a4693a.akpm@linux-foundation.org>
Date:	Sun, 1 Nov 2009 09:35:45 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Huang Ying <ying.huang@...el.com>
Cc:	Joe Perches <joe@...ches.com>,
	Steven Whitehouse <swhiteho@...hat.com>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC 2/2] Use unified UUID/GUID definition in gfs2

On Wed, 14 Oct 2009 14:30:07 +0800 Huang Ying <ying.huang@...el.com> wrote:

> Replace u8[16] UUID definition in gfs2.
> 
> Signed-off-by: Huang Ying <ying.huang@...el.com>
> ---
>  fs/gfs2/incore.h            |    3 ++-
>  fs/gfs2/ops_fstype.c        |    2 +-
>  fs/gfs2/sys.c               |   14 ++++----------
>  include/linux/gfs2_ondisk.h |    3 ++-
>  4 files changed, 9 insertions(+), 13 deletions(-)
> 
> --- a/fs/gfs2/incore.h
> +++ b/fs/gfs2/incore.h
> @@ -15,6 +15,7 @@
>  #include <linux/slow-work.h>
>  #include <linux/dlm.h>
>  #include <linux/buffer_head.h>
> +#include <linux/uuid.h>
>  
>  #define DIO_WAIT	0x00000010
>  #define DIO_METADATA	0x00000020
> @@ -483,7 +484,7 @@ struct gfs2_sb_host {
>  
>  	char sb_lockproto[GFS2_LOCKNAME_LEN];
>  	char sb_locktable[GFS2_LOCKNAME_LEN];
> -	u8 sb_uuid[16];
> +	uuid_be sb_uuid;
>  };
>  

Breaks `make headers_check':

include/linux/gfs2_ondisk.h:14: included file 'linux/uuid.h' is not exported

I don't think we want to export linux/uuid.h to userspace.  But
fs/gfs2/incore.h _is_ shared with userspace, and needs linux/uuid.h.

Don't know what to do, so I'll drop the patches.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/