linux-kernel - Re: [PATCH 12/27] BKL: Remove BKL from btrfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091102121308.GB882@think>
Date:	Mon, 2 Nov 2009 07:13:08 -0500
From:	Chris Mason <chris.mason@...cle.com>
To:	Jan Blunck <jblunck@...e.de>
Cc:	linux-fsdevel@...r.kernel.org, Matthew Wilcox <matthew@....cx>,
	linux-kernel@...r.kernel.org, Christoph Hellwig <hch@....de>,
	Yan Zheng <zheng.yan@...cle.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	Sage Weil <sage@...dream.net>, linux-btrfs@...r.kernel.org
Subject: Re: [PATCH 12/27] BKL: Remove BKL from btrfs

On Mon, Nov 02, 2009 at 11:04:52AM +0100, Jan Blunck wrote:
> BKL is only used in get_sb. It is safe to remove it.
> 
> Signed-off-by: Jan Blunck <jblunck@...e.de>

Acked-by: Chris Mason <chris.mason@...cle.com>

Thanks!

-chris

> ---
>  fs/btrfs/super.c |    8 +-------
>  1 files changed, 1 insertions(+), 7 deletions(-)
> 
> diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
> index e5cd2cf..752a546 100644
> --- a/fs/btrfs/super.c
> +++ b/fs/btrfs/super.c
> @@ -480,17 +480,13 @@ static int btrfs_get_sb(struct file_system_type *fs_type, int flags,
>  	fmode_t mode = FMODE_READ;
>  	int error = 0;
>  
> -	lock_kernel();
> -
>  	if (!(flags & MS_RDONLY))
>  		mode |= FMODE_WRITE;
>  
>  	error = btrfs_parse_early_options(data, mode, fs_type,
>  					  &subvol_name, &fs_devices);
> -	if (error) {
> -		unlock_kernel();
> +	if (error)
>  		return error;
> -	}
>  
>  	error = btrfs_scan_one_device(dev_name, mode, fs_type, &fs_devices);
>  	if (error)
> @@ -559,7 +555,6 @@ static int btrfs_get_sb(struct file_system_type *fs_type, int flags,
>  	mnt->mnt_root = root;
>  
>  	kfree(subvol_name);
> -	unlock_kernel();
>  	return 0;
>  
>  error_s:
> @@ -568,7 +563,6 @@ error_close_devices:
>  	btrfs_close_devices(fs_devices);
>  error_free_subvol_name:
>  	kfree(subvol_name);
> -	unlock_kernel();
>  	return error;
>  }
>  
> -- 
> 1.6.4.2
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/