linux-kernel - Re: [PATCH -v4] crypto: Add PCLMULQDQ accelerated GHASH implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091102143258.GA23776@elte.hu>
Date:	Mon, 2 Nov 2009 15:32:58 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Huang Ying <ying.huang@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
	Daniel Walker <dwalker@...o99.com>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH -v4] crypto: Add PCLMULQDQ accelerated GHASH
	implementation


* Herbert Xu <herbert@...dor.apana.org.au> wrote:

> On Mon, Nov 02, 2009 at 08:50:39AM +0100, Ingo Molnar wrote:
> > 
> > A cleanup request: mind creating two macros for this PSHUFB MMX/SSE 
> > instruction in arch/x86/include/asm/i387.h, instead of open-coding the 
> > .byte sequences in ~6 places?
> 
> I had a go at doing that, but it seems that i387.h isn't really meant 
> to be included in an asm file at this point :)

Please use the standard construct and put an #ifndef __ASSEMBLY__ around 
it.

> > ( After the .33 merge window we'll collect such instruction format 
> >   knowledge in arch/x86/include/asm/inst.h. That file is not upstream 
> >   yet so i387.h will do for now for FPU/SSE instructions. )
> 
> I'm happy to revisit this once inst.h exists.

No reason to not do most of the change first though, the way i suggested 
it.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/