linux-kernel - Re: [PATCH 00/27] Push down BKL to the filesystems (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200911021631.21266.borntraeger@de.ibm.com>
Date:	Mon, 2 Nov 2009 16:31:21 +0100
From:	Christian Borntraeger <borntraeger@...ibm.com>
To:	Jan Blunck <jblunck@...e.de>
Cc:	linux-fsdevel@...r.kernel.org, Matthew Wilcox <matthew@....cx>,
	linux-kernel@...r.kernel.org, Chris Mason <chris.mason@...cle.com>,
	Christoph Hellwig <hch@...radead.org>
Subject: Re: [PATCH 00/27] Push down BKL to the filesystems (v2)

Am Montag 02 November 2009 14:30:42 schrieb Jan Blunck:
> > Looking at
> > you diffstat it seems that you only touched fs/*
> >
> > There are filesystems in other places, e.g.
> > drivers/isdn/capi/capifs.c,
> > arch/powerpc/platforms/cell/spufs/inode.c
> > or
> > arch/s390/hypfs/inode.c
> >
> > I am really not an expert in filesystems, so my comment might be bogus:
> > My expection was, that a simple pushdown should also affect these
> > filesystems, especially if the filesystems dont use simple_fill_super,
> > no?
> 
> D'Oh! You are totally correct. Seems that nothing important outside of fs/
> actually requires the BKL since my box is still wor

Can you change your series to do the full pushdown anyway? grep for 
register_filesystem find several places that probably dont get much testing and 
if something goes wrong a full pushdown + blk removal would allow to find the 
problem with bisect later on.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/