linux-kernel - Re: [ RFC, PATCH - 1/2 ] x86-microcode: refactor microcode output messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091102164621.GF30802@alberich.amd.com>
Date:	Mon, 2 Nov 2009 17:46:21 +0100
From:	Andreas Herrmann <herrmann.der.user@...glemail.com>
To:	dimm <dmitry.adamushko@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com>,
	Mike Travis <travis@....com>,
	Tigran Aivazian <tigran@...azian.fsnet.co.uk>,
	Thomas Gleixner <tglx@...utronix.de>,
	Borislav Petkov <borislav.petkov@....com>,
	Andreas Mohr <andi@...as.de>, Jack Steiner <steiner@....com>,
	linux-kernel@...r.kernel.org
Subject: Re: [ RFC, PATCH - 1/2 ] x86-microcode: refactor microcode output
 messages

On Sun, Nov 01, 2009 at 11:22:59PM +0100, dimm wrote:
> 
> Hi,
> 
> 
> this is in response to Mike's patch "Limit the number of microcode
> messages".
> 
> What's about the following (yet preliminary and not thoroughly tested)
> approach?

Hmm, patch-1 doesn't apply:

 patching file arch/x86/include/asm/microcode.h
 patching file arch/x86/kernel/microcode_amd.c
 Hunk #1 succeeded at 152 (offset -4 lines).
 Hunk #2 succeeded at 240 (offset -7 lines).
 patch: **** malformed patch at line 99: size_t size)

> patch-1:
> 
> simplify 'struct ucode_cpu_info' and related operational logic.
> 
> 
> patch-2: 
> 
> reduce a number of similar 'microcode version' messages by printing a
> single message for all cpus with equal microcode version, like:

Would be useful on systems with many cores.

On AMD multi-socket systems often you have the same CPU revisions and
thus you'd like to have similar ucode on all cores. Hence there is a
high chance that your code would reduce the amount of microcode log
messages during boot.

I'd like to test it but would need patches that do apply ...

Thanks,
Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/