linux-kernel - Re: [PATCH 1/1] PM: Making bdi threads non-freezable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200911021943.49943.rjw@sisk.pl>
Date:	Mon, 2 Nov 2009 19:43:49 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	"Dasgupta, Romit" <romit@...com>
Cc:	"viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-pm@...ts.linux-foundation.org" 
	<linux-pm@...ts.linux-foundation.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>
Subject: Re: [PATCH 1/1] PM: Making bdi threads non-freezable

On Monday 02 November 2009, Dasgupta, Romit wrote:
> Fixes the case when bdi threads are in the refrigerator but file system sync
> can happen after this. This is possible in MMC when CONFIG_MMC_UNSAFE_RESUME is
> not set.

What's going to happen if we attemt to suspend the underlying block device(s)
when the bdi thread are doing their job?  Is there any synchronisation
mechanism for that?

Rafael


> Signed-off-by: Romit Dasgupta <romit@...com>
> ---
>  
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index 9d5360c..661229d 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -956,7 +956,6 @@ int bdi_writeback_task(struct bdi_writeback *wb)
>  
>  		wait_jiffies = msecs_to_jiffies(dirty_writeback_interval * 10);
>  		schedule_timeout_interruptible(wait_jiffies);
> -		try_to_freeze();
>  	}
>  
>  	return 0;
> diff --git a/mm/backing-dev.c b/mm/backing-dev.c
> index 5a37e20..9383271 100644
> --- a/mm/backing-dev.c
> +++ b/mm/backing-dev.c
> @@ -273,7 +273,6 @@ static void bdi_task_init(struct backing_dev_info *bdi,
>  	spin_unlock(&bdi->wb_lock);
>  
>  	tsk->flags |= PF_FLUSHER | PF_SWAPWRITE;
> -	set_freezable();
>  
>  	/*
>  	 * Our parent may run at a different priority, just set us to normal
> @@ -419,7 +418,6 @@ static int bdi_forker_task(void *ptr)
>  			spin_unlock_bh(&bdi_lock);
>  			wait = msecs_to_jiffies(dirty_writeback_interval * 10);
>  			schedule_timeout(wait);
> -			try_to_freeze();
>  			continue;
>  		}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/