linux-kernel - Re: [RFC][PATCH 1/7] Adding general performance benchmarking subsystem to perf.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091103073354.GC19928@elte.hu>
Date:	Tue, 3 Nov 2009 08:33:54 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Hitoshi Mitake <mitake@....info.waseda.ac.jp>
Cc:	linux-kernel@...r.kernel.org,
	Rusty Russell <rusty@...tcorp.com.au>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Mike Galbraith <efault@....de>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Frédéric_Weisbecker <fweisbec@...il.com>
Subject: Re: [RFC][PATCH 1/7] Adding general performance benchmarking
	subsystem to perf.


* Hitoshi Mitake <mitake@....info.waseda.ac.jp> wrote:

> 
> Adding general performance benchmarking subsystem to perf.
> This patch modifies Makefile of perf to build new source files.
> 
> Signed-off-by: Hitoshi Mitake <mitake@....info.waseda.ac.jp>
> Cc: Rusty Russell <rusty@...tcorp.com.au>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Cc: Mike Galbraith <efault@....de>
> ---
>  tools/perf/Makefile |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> index 7e190d5..f6f7a6b 100644
> --- a/tools/perf/Makefile
> +++ b/tools/perf/Makefile
> @@ -391,6 +391,9 @@ BUILTIN_OBJS += builtin-stat.o
>  BUILTIN_OBJS += builtin-timechart.o
>  BUILTIN_OBJS += builtin-top.o
>  BUILTIN_OBJS += builtin-trace.o
> +BUILTIN_OBJS += builtin-bench.o
> +BUILTIN_OBJS += builtin-bench-messaging.o
> +BUILTIN_OBJS += builtin-bench-pipe.o

The series should be bisectable (i.e. build at every step) - so i'd 
suggest to add this Makefile bit to the patch that adds the .c, or move 
the .c addition before the Makefile addition patch.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/