linux-kernel - Re: [RFC][PATCH 2/7] Adding general performance benchmarking subsystem to perf.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091103074749.GH19928@elte.hu>
Date:	Tue, 3 Nov 2009 08:47:49 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Hitoshi Mitake <mitake@....info.waseda.ac.jp>
Cc:	linux-kernel@...r.kernel.org,
	Rusty Russell <rusty@...tcorp.com.au>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Mike Galbraith <efault@....de>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Frédéric_Weisbecker <fweisbec@...il.com>
Subject: Re: [RFC][PATCH 2/7] Adding general performance benchmarking
	subsystem to perf.


* Ingo Molnar <mingo@...e.hu> wrote:

> 
> * Hitoshi Mitake <mitake@....info.waseda.ac.jp> wrote:
> 
> > 
> > Adding general performance benchmarking subsystem to perf.
> > This patch add new file: bench-suite.h
> > 
> > bench-suite.h contains prototypes of benchmark suite functions.
> > 
> > Signed-off-by: Hitoshi Mitake <mitake@....info.waseda.ac.jp>
> > Cc: Rusty Russell <rusty@...tcorp.com.au>
> > Cc: Thomas Gleixner <tglx@...utronix.de>
> > Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> > Cc: Mike Galbraith <efault@....de>
> > ---
> >  tools/perf/bench-suite.h |    7 +++++++
> >  1 files changed, 7 insertions(+), 0 deletions(-)
> >  create mode 100644 tools/perf/bench-suite.h
> > 
> > diff --git a/tools/perf/bench-suite.h b/tools/perf/bench-suite.h
> > new file mode 100644
> > index 0000000..65f6f55
> > --- /dev/null
> > +++ b/tools/perf/bench-suite.h
> > @@ -0,0 +1,7 @@
> > +#ifndef BENCH_SUITE_H
> > +#define BENCH_SUITE_H
> > +
> > +extern int bench_sched_messaging(int argc, const char **argv, const char *prefix);
> > +extern int bench_sched_pipe(int argc, const char **argv, const char *prefix);
> > +
> > +#endif
> 
> Please put new headers into tools/*.h.
> 
> Also, could we name it bench.h? It's a bit shorter :)

As per my later mail, maybe the better place for this header would be 
tools/perf/bench/bench.h. That makes the addition of new benchmark 
modules rather self-sufficient.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/