[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1257241821.4269.5.camel@utx.utx.cz>
Date: Tue, 03 Nov 2009 10:50:21 +0100
From: Stanislav Brabec <utx@...guin.cz>
To: Haojian Zhuang <haojian.zhuang@...il.com>
Cc: Pavel Machek <pavel@....cz>, dsaxena@...top.org,
alan@...ux.intel.com, gregkh@...e.de,
Daniel Mack <daniel@...aq.de>,
linux-arm-kernel@...ts.infradead.org, Eric <eric.y.miao@...il.com>,
Haojian Zhuang <haojian.zhuang@...vell.com>, rpurdie@...ys.net,
lenz@...wisc.edu, kernel list <linux-kernel@...r.kernel.org>,
Dirk@...er-online.de, arminlitzel@....de,
Cyril Hrubis <metan@....cz>, thommycheck@...il.com,
dbaryshkov@...il.com, omegamoon@...il.com,
"Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: Possible suspend/resume regression in .32-rc?
Haojian Zhuang wrote:
> On Mon, Nov 2, 2009 at 5:57 AM, Stanislav Brabec <utx@...guin.cz> wrote:
> > Haojian Zhuang wrote:
> >
> >> Commit b5b82df6, from May 2007, breaks no_console_suspend on the OLPC
> >> XO laptop. Basically what happens is that upon returning from resume,
> >> serial8250_resume_port() will reconfigure the port for high speed
> >> mode and all console output will be garbled, making debug of the
> >> resume path painful. This patch modifies uart_resume_port() to
> >> reset the port to the state it was in before we suspended.
> >
> > See my patch waiting for approval in LKML thread
> > "serial-core: resume serial hardware with no_console_suspend".
> >
> > It attempts to fix it, but I was not yet able to test it due to spitz
> > resume breakage.
> >
>
> Hi Stanislav,
>
> At first, your patch can't be applied into my latest codebase. I have
> to update the patch. But the console resume is still blocked after
> applied your patch. It works only after I merge some old code back. My
> modified patch is in below.
Yes, code changed there a bit. I sent rebased patch later in the thread.
Did you try this one? (Well I did not test it yet - in time of sending
resume did not work at all on my Zaurus.)
Your patch is a bit different. I'll test both as soon as possible.
________________________________________________________________________
Stanislav Brabec
http://www.penguin.cz/~utx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists