[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20091103100232.GA489@merkur.ravnborg.org>
Date: Tue, 3 Nov 2009 11:02:32 +0100
From: Sam Ravnborg <sam@...nborg.org>
To: Huang Ying <ying.huang@...el.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Joe Perches <joe@...ches.com>,
Steven Whitehouse <swhiteho@...hat.com>,
Laurent Pinchart <laurent.pinchart@...asonboard.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC 2/2] Use unified UUID/GUID definition in gfs2
On Tue, Nov 03, 2009 at 03:21:59PM +0800, Huang Ying wrote:
> On Tue, 2009-11-03 at 09:02 +0800, Andrew Morton wrote:
> > On Tue, 03 Nov 2009 08:44:48 +0800
> > Huang Ying <ying.huang@...el.com> wrote:
> >
> > > For stuff of no use to user space, I think it can be enclosed into
> > >
> > > #ifdef __KERNEL__
> > > #endif
> >
> > It can, but that's ugly. Clearly separating the inclusions into uuid-kernel.h
> > and uuid-user-h is nicer, no?
>
> But it seems that __KERNEL__ is common used method now. There are about
> 370 out of 3085 files under linux/include use __KERNEL__.
Just because we were sloopy in the past is no excuse for repeating this.
Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists