linux-kernel - Re: [PATCH] at91: at91sam9g20ek modify dual slot evaluation kit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 03 Nov 2009 13:04:35 +0100
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
CC:	linux-arm-kernel@...ts.infradead.org, avictor.za@...il.com,
	akpm@...ux-foundation.org, linux-mmc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] at91: at91sam9g20ek modify dual slot evaluation kit

Jean-Christophe PLAGNIOL-VILLARD :
>> +	  that embeds only one SD/MMC slot.
>> +
>> +config MACH_AT91SAM9G20EK_2MMC
>> +	bool "Atmel AT91SAM9G20-EK Evaluation Kit with 2 SD/MMC Slots"
>> +	depends on ARCH_AT91SAM9G20
>> +	help
>> +	  Select this if you are using an Atmel AT91SAM9G20-EK Evaluation Kit
>> +	  with 2 SD/MMC Slots. This is the case for AT91SAM9G20-EK rev. C and
>> +	  onwards.
>>  
>>  config MACH_CPU9G20
>>  	bool "Eukrea CPU9G20 board"
>> @@ -392,7 +394,7 @@ config MTD_AT91_DATAFLASH_CARD
>>  
>>  config MTD_NAND_ATMEL_BUSWIDTH_16
>>  	bool "Enable 16-bit data bus interface to NAND flash"
>> -	depends on (MACH_AT91SAM9260EK || MACH_AT91SAM9261EK || MACH_AT91SAM9G10EK || MACH_AT91SAM9263EK || MACH_AT91SAM9G20EK || MACH_AT91SAM9G45EKES || MACH_AT91CAP9ADK)
>> +	depends on (MACH_AT91SAM9260EK || MACH_AT91SAM9261EK || MACH_AT91SAM9G10EK || MACH_AT91SAM9263EK || MACH_AT91SAM9G20EK || MACH_AT91SAM9G20EK_2MMC || MACH_AT91SAM9G45EKES || MACH_AT91CAP9ADK)
> it's time to replace this by select it at machine config state

Ok patches are comming now on top of this one.

>> @@ -254,7 +257,11 @@ static void __init ek_board_init(void)
>>  	/* Ethernet */
>>  	at91_add_device_eth(&ek_macb_data);
>>  	/* MMC */
>> +#if defined(CONFIG_MMC_ATMELMCI) || defined(CONFIG_MMC_ATMELMCI_MODULE)
>>  	at91_add_device_mci(0, &ek_mmc_data);
>> +#else
>> +	at91_add_device_mmc(0, &ek_mmc_data);
>> +#endif
> do we really need to do this choice at board level?

Yes, you will choose on your board which driver will drive your sd/mmc
interface. The device file will give access to both of them.

Best regards,
-- 
Nicolas Ferre

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/