linux-kernel - [PATCH][RFC] Removing wrong judgement of checkpatch.pl for return as function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091103.104932.625281420231629894.mitake@dcl.info.waseda.ac.jp>
Date:	Tue, 03 Nov 2009 10:49:32 +0900 (JST)
From:	Hitoshi Mitake <mitake@....info.waseda.ac.jp>
To:	Andy Whitcroft <apw@...onical.com>, linux-kernel@...r.kernel.org
Subject: [PATCH][RFC] Removing wrong judgement of checkpatch.pl for return
 as function


Hi,

I found a strange behaviour of checkpatch.pl.

The C statement:
	return (type)value;
is regarded as return like a function form by checkpatch.pl.
So checkpatch.pl causes "Return is not a function." error
when processing statements like this.

I think statements like above are innocence. These are only doing type cast.
This patch removes the behaviour of checkpatch.pl.

But I don't have confidence about coding style of Linux kernel.
Is my thought correct? Or the behaviour of current checkpatch.pl is correct?
Request for comment.

Signed-off-by: Hitoshi Mitake <mitake@....info.waseda.ac.jp>

---
 scripts/checkpatch.pl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index bc4114f..04a876c 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2117,7 +2117,7 @@ sub process {
 		}
 
 # Return is not a function.
-		if (defined($stat) && $stat =~ /^.\s*return(\s*)(\(.*);/s) {
+		if (defined($stat) && $stat =~ /^.\s*return(\s*)(\(.*)\);/s) {
 			my $spacing = $1;
 			my $value = $2;
 
-- 
1.5.6.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/