linux-kernel - Re: [PATCH 01/27] BKL: Push down BKL from do_new_mount() to the filesystems get_sb/fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091103143333.GA2740@infradead.org>
Date:	Tue, 3 Nov 2009 09:33:33 -0500
From:	Christoph Hellwig <hch@...radead.org>
To:	Jan Blunck <jblunck@...e.de>
Cc:	Christoph Hellwig <hch@...radead.org>,
	linux-fsdevel@...r.kernel.org, Matthew Wilcox <matthew@....cx>,
	Linux-Kernel Mailinglist <linux-kernel@...r.kernel.org>,
	Christian Borntraeger <borntraeger@...ibm.com>
Subject: Re: [PATCH 01/27] BKL: Push down BKL from do_new_mount() to the
	filesystems get_sb/fill_super operation

On Tue, Nov 03, 2009 at 11:25:09AM +0100, Jan Blunck wrote:
> > For the next spin please don't push it down to filesystems that
> > obviously don't need it at all and just mention them in the patch
> > description.  For filesystems like xfs and btrfs that never used the BKL
> > at all that should make life a bit simpler.
> 
> My plan was to remove the BKL in the obvious cases in the followup patches
> that are also included in the series. So should I just merge the obvious stuff
> into one patch? Christian Borntraeger was actually requesting the opposite. He
> wants to be able to bisect it to the patch that is removing the BKL. That
> would be much simple with many small patches I think.

Yes, but for most filesystems the BKL never made sense.  Anywhere where
it's non-obvious (or the maintainer wants it) make it a separate patch,
but don't bother for things like xfs or btrfs.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/