linux-kernel - Re: [PATCH -rt] Updates-from-Jon-Masters-for-hwlat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 03 Nov 2009 10:17:21 -0500
From:	Jon Masters <jcm@...hat.com>
To:	John Kacur <jkacur@...hat.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org,
	linux-rt-users@...r.kernel.org,
	Clark Williams <williams@...hat.com>
Subject: Re: [PATCH -rt] Updates-from-Jon-Masters-for-hwlat_detector.c.patch

On Mon, 2009-11-02 at 20:46 +0100, John Kacur wrote:
> On Mon, Nov 2, 2009 at 4:43 PM, Thomas Gleixner <tglx@...utronix.de> wrote:

> >> diff --git a/drivers/misc/hwlat_detector.c b/drivers/misc/hwlat_detector.c
> >> index be6553f..7191e17 100644
> >> --- a/drivers/misc/hwlat_detector.c
> >> +++ b/drivers/misc/hwlat_detector.c
> >> @@ -262,6 +262,8 @@ static int get_sample(void *unused)
> >>               /* Keep a running maximum ever recorded hardware latency */
> >>               if (sample > data.max_sample)
> >>                       data.max_sample = sample;
> >> +
> >> +             wake_up(&data.wq); /* wake up reader(s) */
> >>       }
> >>
> >>       ret = 0;
> >> @@ -299,8 +301,6 @@ static int kthread_fn(void *unused)
> >>                       goto err_out;
> >>               }
> >>
> >> -             wake_up(&data.wq); /* wake up reader(s) */
> >> -
> >
> > This reverts -rt commit 5fc485f6341c177e9d5f641c6fb9e33ca465aa84.
> >
> > CONFIG_DEBUG_SPINLOCK_SLEEP resp. CONFIG_DEBUG_PREEMPT will tell you
> > why this is a bad idea on -rt :)
> >
> > Thanks,
> >
> >        tglx
> > --
> 
> Ugh. Thanks for catching that. To be honest not sure how it happened,
> so it must be my fault. :)
> 
> Updated patch just adds the error checking from Jon Masters then,
> patched against -rt.

Actually, I think it might be my fault. I'll talk to you about the best
way to proceed with updates since we're still looking for a reproducer
on that lockup Clark was seeing a while back.

Jon.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/