linux-kernel - Re: Please consider reverting 7d930bc33653d5592dc386a76a38f39c2e962344

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.01.0911030726420.31845@localhost.localdomain>
Date:	Tue, 3 Nov 2009 07:31:06 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Johannes Berg <johannes@...solutions.net>
cc:	Marcel Holtmann <marcel@...tmann.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	David Miller <davem@...emloft.net>, linville@...driver.com,
	linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org
Subject: Re: Please consider reverting
 7d930bc33653d5592dc386a76a38f39c2e962344

On Tue, 3 Nov 2009, Johannes Berg wrote:
> 
> I'll rant a bit too -- I've been very annoyed by this many times. Note
> this isn't really against you (Dmitry) in particular, just another
> case ... but it does tick me off that many times when somebody manages
> to blame a failure on a specific commit the first thing they do is ask
> somebody way "above" (in terms of patch flow into mainline) the person
> writing the patch (like Linus here) to revert it.

Johannes, you're simply WRONG.

At this point (ie _way_ after -rc1), "just revert it" really is the right 
thing to do. The commit was shit. It caused more problems than it fixed. I 
should have reverted it immediately when that was clear. I didn't, and 
because I didn't, other people then had to waste time bisecting it.

So instead of complaining about other people, I would suggest you look 
yourself in the mirror. Stop thinking you "own" code. If you wrote a buggy 
commit, and somebody else went through the work to bisect it, you should 
 (a) expect it to be reverted
 (b) thank the person for finding the bug YOU introduced.
 (c) be ashamed of YOURSELF
instead of whining about it as if we should thank you!

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/