linux-kernel - Re: Please consider reverting 7d930bc33653d5592dc386a76a38f39c2e962344

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.01.0911030738260.31845@localhost.localdomain>
Date:	Tue, 3 Nov 2009 07:43:02 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Marcel Holtmann <marcel@...tmann.org>
cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	David Miller <davem@...emloft.net>, johannes@...solutions.net,
	linville@...driver.com, linux-kernel@...r.kernel.org,
	linux-wireless@...r.kernel.org
Subject: Re: Please consider reverting
 7d930bc33653d5592dc386a76a38f39c2e962344

On Wed, 4 Nov 2009, Marcel Holtmann wrote:
> 
> no questions that it needs fixed, I agree with you. However just blindly
> reverting something, because it fixes it for one or two people, might
> have side effects that causes more problems than the revert would
> actually fix.

Stop whining. Really.

Everybody understands that it should be fixed.  That's not the question.

But it should be fixed _quickly_. In this case, I have a bisection report 
FROM TWO DAYS AGO. And I'm still kicking myself for not just reverting 
that piece-of-shit commit then, because I spent the time to look at the 
oops and the commit, and could tell that it was crap.

Instead, I _did_ wait for the subsystem maintainer to get around to it. As 
a result of waiting, I've now wasted time for a lot of other people.

So stop your claptrap. You're wrong. I would suggest you now thank Dmitry, 
and ask his forgiveness for (a) wasting his time and (b) then berating him 
for it.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/