linux-kernel - Re: Please consider reverting 7d930bc33653d5592dc386a76a38f39c2e962344

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.01.0911030851440.31845@localhost.localdomain>
Date:	Tue, 3 Nov 2009 08:59:36 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Marcel Holtmann <marcel@...tmann.org>
cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	David Miller <davem@...emloft.net>, johannes@...solutions.net,
	linville@...driver.com, linux-kernel@...r.kernel.org,
	linux-wireless@...r.kernel.org
Subject: Re: Please consider reverting
 7d930bc33653d5592dc386a76a38f39c2e962344



On Wed, 4 Nov 2009, Marcel Holtmann wrote:
> 
> However to be fair here, this one didn't hit everybody. I for myself
> haven't seen it at all and actually I have been running this "faulty"
> kernel for a while now and suspending happily multiple times a day. As
> much as you hate that the patch for this bug took longer than needed to
> find its way into your tree, the immediate need and the wide problem was
> not clear.

I do not agree.

A _single_ NULL pointer report should have made it clear. As mentioned, I 
was involved in one of the "please revert" threads, and I looked at the 
code, and it was obviously bogus. I could (and did) point to the exact 
memcpy() that caused the problem.

There really was no excuse. That 7d930bc33 commit had a NULL pointer 
dereference, and people hit it. End of story.

The fact that not _all_ people hit it explains how it got pulled into my 
tree in the first place, but that's it.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/