linux-kernel - Re: kernel building regression on 32-rc5 kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091103183235.GD8742@kernel.dk>
Date:	Tue, 3 Nov 2009 19:32:36 +0100
From:	Jens Axboe <jens.axboe@...cle.com>
To:	"Shi, Alex" <alex.shi@...el.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: kernel building regression on 32-rc5 kernel

On Tue, Nov 03 2009, Shi, Alex wrote:
> I found the kernel building will have about 20%~ 30% regressions on
> our NHM machines. My kernel build do the following things 15 times:
> 
> make mrproper; echo \"3\">/proc/sys/vm/drop_caches; make defconfig;
> make -j${2timescpunumbers}
> 
> 
> 
> Bisect found it is due to the commitment:
> 
> commit a6151c3a5c8e1ff5a28450bc8d6a99a2a0add0a7

I looked over that commit and found one typo, can you check with this
patch applied?

diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
index 069a610..5802e32 100644
--- a/block/cfq-iosched.c
+++ b/block/cfq-iosched.c
@@ -2051,7 +2051,7 @@ cfq_should_preempt(struct cfq_data *cfqd, struct cfq_queue *new_cfqq,
 	 * it's a metadata request and the current queue is doing regular IO.
 	 */
 	if (rq_is_meta(rq) && !cfqq->meta_pending)
-		return false;
+		return true;
 
 	/*
 	 * Allow an RT request to pre-empt an ongoing non-RT cfqq timeslice.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/