linux-kernel - Re: [PATCH 1/1] PM: Making bdi threads non-freezable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200911032203.57757.rjw@sisk.pl>
Date:	Tue, 3 Nov 2009 22:03:57 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	"Dasgupta, Romit" <romit@...com>
Cc:	"viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-pm@...ts.linux-foundation.org" 
	<linux-pm@...ts.linux-foundation.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>
Subject: Re: [PATCH 1/1] PM: Making bdi threads non-freezable

On Tuesday 03 November 2009, Dasgupta, Romit wrote:
> 
> > Subject: Re: [PATCH 1/1] PM: Making bdi threads non-freezable
> > 
> > On Monday 02 November 2009, Dasgupta, Romit wrote:
> > > Fixes the case when bdi threads are in the refrigerator but file system sync
> > > can happen after this. This is possible in MMC when
> > CONFIG_MMC_UNSAFE_RESUME is
> > > not set.
> > 
> > What's going to happen if we attemt to suspend the underlying block device(s)
> > when the bdi thread are doing their job?  Is there any synchronisation
> > mechanism for that?
> > 
> There is no explicit synchronization AFAICT. However, it looks like the call
> to 'del_gendisk' would invoke 'sync_filesystem' down the line.
> 'sync_filesystem' would end with synchronous writes of inodes followed by a
> call to '__sync_blockddev'.

However, that runs concurrently with respect to the suspend thread, AFAICS, so
I wonder if there's anything to make the suspend thread wait for these
operations to complete.  If there's nothing like that, we can't really allow
the bdi threads to run in parallel with the suspend thread.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/