linux-kernel - Re: [patch 18/28] watchdog: Remove BKL from rio watchdog driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091102.211640.184762927.davem@davemloft.net>
Date:	Mon, 02 Nov 2009 21:16:40 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	tglx@...utronix.de
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	mingo@...e.hu, peterz@...radead.org, fweisbec@...il.com,
	vince@...tec.co.uk, jkacur@...hat.com, corbet@....net,
	hch@...radead.org
Subject: Re: [patch 18/28] watchdog: Remove BKL from rio watchdog driver

From: Thomas Gleixner <tglx@...utronix.de>
Date: Sat, 10 Oct 2009 15:36:48 -0000

> cycle_kernel_lock() was added with the BKL pushdown. The rio driver
> indeed needs that because riowd_device is initialized after
> misc_register(). So an open(), write/ioctl() which happens to get
> between misc_register returning and riowd_device initialization would
> dereference a NULL pointer.
> 
> Move riowd_device initialization before misc_register() and get rid of
> cycle_kernel_lock().
> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>

Also applied to sparc-next-2.6, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/