[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <m1hbta4lwb.fsf@fess.ebiederm.org>
Date: Wed, 04 Nov 2009 02:36:20 -0800
From: ebiederm@...ssion.com (Eric W. Biederman)
To: Greg Kroah-Hartman <gregkh@...e.de>
Cc: <linux-fsdevel@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
sds@...ho.nsa.gov, jmorris@...ei.org, casey@...aufler-ca.com,
linux-security-module@...r.kernel.org
Subject: Re: [PATCH] sysfs: Don't leak secdata when a sysfs_dirent is freed.
Grr. Please all ignore the 01/42 in the subject. Clearly I was
a bit too tired when I sent this but the fix is good and fixes a bug
2.6.32-rc5 that should be there in the first place.
ebiederm@...ssion.com (Eric W. Biederman) writes:
> While refreshing my sysfs patches I noticed a leak in the secdata
> implementation. We don't free the secdata when we free the
> sysfs dirent.
>
> This is a bug in 2.6.32-rc5 that we really should close.
>
> Signed-off-by: Eric W. Biederman <ebiederm@...stanetworks.com>
> ---
> fs/sysfs/dir.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c
> index 5fad489..e020183 100644
> --- a/fs/sysfs/dir.c
> +++ b/fs/sysfs/dir.c
> @@ -21,6 +21,7 @@
> #include <linux/completion.h>
> #include <linux/mutex.h>
> #include <linux/slab.h>
> +#include <linux/security.h>
> #include "sysfs.h"
>
> DEFINE_MUTEX(sysfs_mutex);
> @@ -285,6 +286,9 @@ void release_sysfs_dirent(struct sysfs_dirent * sd)
> sysfs_put(sd->s_symlink.target_sd);
> if (sysfs_type(sd) & SYSFS_COPY_NAME)
> kfree(sd->s_name);
> + if (sd->s_iattr && sd->s_iattr->ia_secdata)
> + security_release_secctx(sd->s_iattr->ia_secdata,
> + sd->s_iattr->ia_secdata_len);
> kfree(sd->s_iattr);
> sysfs_free_ino(sd->s_ino);
> kmem_cache_free(sysfs_dir_cachep, sd);
> --
> 1.6.5.2.143.g8cc62
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists