linux-kernel - Re: [PATCH 15/13] sysfs: Protect sysfs_refresh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091104142716.GD4355@us.ibm.com>
Date:	Wed, 4 Nov 2009 08:27:16 -0600
From:	"Serge E. Hallyn" <serue@...ibm.com>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>,
	Kay Sievers <kay.sievers@...y.org>, Greg KH <greg@...ah.com>,
	linux-kernel@...r.kernel.org, Tejun Heo <tj@...nel.org>,
	Cornelia Huck <cornelia.huck@...ibm.com>,
	linux-fsdevel@...r.kernel.org,
	Eric Dumazet <eric.dumazet@...il.com>,
	Benjamin LaHaise <bcrl@...et.ca>
Subject: Re: [PATCH 15/13] sysfs: Protect sysfs_refresh_inode with inode
	mutex.

Quoting Eric W. Biederman (ebiederm@...ssion.com):
> 
> In general everything that writes to vfs inodes holds the
> inode mutex, so hold the inode mutex over sysfs_refresh_inode.
> The sysfs data structures don't need this but it looks like the
> vfs might.
> 
> Signed-off-by: Eric W. Biederman <ebiederm@...stanetworks.com>

Oh right so pls disregard my last reply to patch 9 :)


Acked-by: Serge Hallyn <serue@...ibm.com>

> ---
>  fs/sysfs/inode.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/sysfs/inode.c b/fs/sysfs/inode.c
> index e2595a7..ad549f5 100644
> --- a/fs/sysfs/inode.c
> +++ b/fs/sysfs/inode.c
> @@ -240,9 +240,11 @@ int sysfs_getattr(struct vfsmount *mnt, struct dentry *dentry, struct kstat *sta
>  	struct sysfs_dirent *sd = dentry->d_fsdata;
>  	struct inode *inode = dentry->d_inode;
> 
> +	mutex_lock(&inode->i_mutex);
>  	mutex_lock(&sysfs_mutex);
>  	sysfs_refresh_inode(sd, inode);
>  	mutex_unlock(&sysfs_mutex);
> +	mutex_unlock(&inode->i_mutex);
> 
>  	generic_fillattr(inode, stat);
>  	return 0;
> @@ -353,9 +355,11 @@ int sysfs_permission(struct inode *inode, int mask)
>  {
>  	struct sysfs_dirent *sd = inode->i_private;
> 
> +	mutex_lock(&inode->i_mutex);
>  	mutex_lock(&sysfs_mutex);
>  	sysfs_refresh_inode(sd, inode);
>  	mutex_unlock(&sysfs_mutex);
> +	mutex_unlock(&inode->i_mutex);
> 
>  	return generic_permission(inode, mask, NULL);
>  }
> -- 
> 1.6.5.2.143.g8cc62
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/