linux-kernel - Re: [PATCH 05/13] sysfs: Simplify iattr time assignments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091104025718.GB27639@us.ibm.com>
Date:	Tue, 3 Nov 2009 20:57:18 -0600
From:	"Serge E. Hallyn" <serue@...ibm.com>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>,
	Kay Sievers <kay.sievers@...y.org>, Greg KH <greg@...ah.com>,
	linux-kernel@...r.kernel.org, Tejun Heo <tj@...nel.org>,
	Cornelia Huck <cornelia.huck@...ibm.com>,
	linux-fsdevel@...r.kernel.org,
	Eric Dumazet <eric.dumazet@...il.com>,
	Benjamin LaHaise <bcrl@...et.ca>,
	"Eric W. Biederman" <ebiederm@...stanetworks.com>
Subject: Re: [PATCH 05/13] sysfs: Simplify iattr time assignments

Quoting Eric W. Biederman (ebiederm@...ssion.com):
> From: Eric W. Biederman <ebiederm@...ssion.com>
> 
> The granularity of sysfs time when we keep it is 1 ns.  Which
> when passed to timestamp_trunc results in a nop.  So remove
> the unnecessary function call making sysfs_setattr slightly
> easier to read.
> 
> Acked-by: Tejun Heo <tj@...nel.org>
> Signed-off-by: Eric W. Biederman <ebiederm@...stanetworks.com>

Acked-by: Serge Hallyn <serue@...ibm.com>

> ---
>  fs/sysfs/inode.c |    9 +++------
>  1 files changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/fs/sysfs/inode.c b/fs/sysfs/inode.c
> index 8a08250..fed7a74 100644
> --- a/fs/sysfs/inode.c
> +++ b/fs/sysfs/inode.c
> @@ -103,14 +103,11 @@ int sysfs_setattr(struct dentry * dentry, struct iattr * iattr)
>  		if (ia_valid & ATTR_GID)
>  			iattrs->ia_gid = iattr->ia_gid;
>  		if (ia_valid & ATTR_ATIME)
> -			iattrs->ia_atime = timespec_trunc(iattr->ia_atime,
> -					inode->i_sb->s_time_gran);
> +			iattrs->ia_atime = iattr->ia_atime;
>  		if (ia_valid & ATTR_MTIME)
> -			iattrs->ia_mtime = timespec_trunc(iattr->ia_mtime,
> -					inode->i_sb->s_time_gran);
> +			iattrs->ia_mtime = iattr->ia_mtime;
>  		if (ia_valid & ATTR_CTIME)
> -			iattrs->ia_ctime = timespec_trunc(iattr->ia_ctime,
> -					inode->i_sb->s_time_gran);
> +			iattrs->ia_ctime = iattr->ia_ctime;
>  		if (ia_valid & ATTR_MODE) {
>  			umode_t mode = iattr->ia_mode;
> 
> -- 
> 1.6.5.2.143.g8cc62
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/