linux-kernel - Re: [PATCH 07/13] sysfs: Update s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091104035413.GD27639@us.ibm.com>
Date:	Tue, 3 Nov 2009 21:54:13 -0600
From:	"Serge E. Hallyn" <serue@...ibm.com>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>,
	Kay Sievers <kay.sievers@...y.org>, Greg KH <greg@...ah.com>,
	linux-kernel@...r.kernel.org, Tejun Heo <tj@...nel.org>,
	Cornelia Huck <cornelia.huck@...ibm.com>,
	linux-fsdevel@...r.kernel.org,
	Eric Dumazet <eric.dumazet@...il.com>,
	Benjamin LaHaise <bcrl@...et.ca>,
	"Eric W. Biederman" <ebiederm@...stanetworks.com>
Subject: Re: [PATCH 07/13] sysfs: Update s_iattr on link and unlink.

Quoting Eric W. Biederman (ebiederm@...ssion.com):
> From: Eric W. Biederman <ebiederm@...ssion.com>
> 
> Currently sysfs updates the timestamps on the vfs directory
> inode when we create or remove a directory entry but doesn't
> update the cached copy on the sysfs_dirent, fix that oversight.

confused... why not do this in sysfs_addrm_finish()?

I guess you'd have to do at it at top before dropping sysfs_mutex
so it wouldn't be as pretty as I was thinking, but at least you
could just do it once.

> 
> Acked-by: Tejun Heo <tj@...nel.org>
> Signed-off-by: Eric W. Biederman <ebiederm@...stanetworks.com>
> ---
>  fs/sysfs/dir.c |   18 ++++++++++++++++++
>  1 files changed, 18 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c
> index b5e8499..fa37126 100644
> --- a/fs/sysfs/dir.c
> +++ b/fs/sysfs/dir.c
> @@ -464,6 +464,8 @@ void sysfs_addrm_start(struct sysfs_addrm_cxt *acxt,
>   */
>  int __sysfs_add_one(struct sysfs_addrm_cxt *acxt, struct sysfs_dirent *sd)
>  {
> +	struct sysfs_inode_attrs *ps_iattr;
> +
>  	if (sysfs_find_dirent(acxt->parent_sd, sd->s_name))
>  		return -EEXIST;
> 
> @@ -476,6 +478,13 @@ int __sysfs_add_one(struct sysfs_addrm_cxt *acxt, struct sysfs_dirent *sd)
> 
>  	sysfs_link_sibling(sd);
> 
> +	/* Update timestamps on the parent */
> +	ps_iattr = acxt->parent_sd->s_iattr;
> +	if (ps_iattr) {
> +		struct iattr *ps_iattrs = &ps_iattr->ia_iattr;
> +		ps_iattrs->ia_ctime = ps_iattrs->ia_mtime = CURRENT_TIME;
> +	}
> +
>  	return 0;
>  }
> 
> @@ -554,10 +563,19 @@ int sysfs_add_one(struct sysfs_addrm_cxt *acxt, struct sysfs_dirent *sd)
>   */
>  void sysfs_remove_one(struct sysfs_addrm_cxt *acxt, struct sysfs_dirent *sd)
>  {
> +	struct sysfs_inode_attrs *ps_iattr;
> +
>  	BUG_ON(sd->s_flags & SYSFS_FLAG_REMOVED);
> 
>  	sysfs_unlink_sibling(sd);
> 
> +	/* Update timestamps on the parent */
> +	ps_iattr = acxt->parent_sd->s_iattr;
> +	if (ps_iattr) {
> +		struct iattr *ps_iattrs = &ps_iattr->ia_iattr;
> +		ps_iattrs->ia_ctime = ps_iattrs->ia_mtime = CURRENT_TIME;
> +	}
> +
>  	sd->s_flags |= SYSFS_FLAG_REMOVED;
>  	sd->s_sibling = acxt->removed;
>  	acxt->removed = sd;
> -- 
> 1.6.5.2.143.g8cc62
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/