[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20091105111151.GC4877@nowhere>
Date: Thu, 5 Nov 2009 12:11:53 +0100
From: Frederic Weisbecker <fweisbec@...il.com>
To: Paul Mackerras <paulus@...ba.org>
Cc: Ingo Molnar <mingo@...e.hu>, LKML <linux-kernel@...r.kernel.org>,
Prasad <prasad@...ux.vnet.ibm.com>,
Alan Stern <stern@...land.harvard.edu>,
Peter Zijlstra <peterz@...radead.org>,
Arnaldo Carvalho de Melo <acme@...hat.com>,
Steven Rostedt <rostedt@...dmis.org>,
Jan Kiszka <jan.kiszka@....de>,
Jiri Slaby <jirislaby@...il.com>,
Li Zefan <lizf@...fujitsu.com>, Avi Kivity <avi@...hat.com>,
Mike Galbraith <efault@....de>,
Masami Hiramatsu <mhiramat@...hat.com>,
Paul Mundt <lethal@...ux-sh.org>
Subject: Re: [PATCH 4/6] hw-breakpoints: Rewrite the hw-breakpoints layer
on top of perf events
On Thu, Nov 05, 2009 at 10:03:36PM +1100, Paul Mackerras wrote:
> Frederic Weisbecker writes:
>
> > @@ -207,6 +212,15 @@ struct perf_event_attr {
> > __u32 wakeup_events; /* wakeup every n events */
> > __u32 wakeup_watermark; /* bytes before wakeup */
> > };
> > +
> > + union {
> > + struct { /* Hardware breakpoint info */
> > + __u64 bp_addr;
> > + __u32 bp_type;
> > + __u32 bp_len;
> > + };
> > + };
>
> I'm wondering why you don't use attr.config for anything with
> breakpoint events?
>
> Paul.
Because this is not sufficient to host the breakpoint parameters
given from userspace. May be I'm missing something?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists