linux-kernel - Re: [PATCH] IXP4xx: Ensure index is positive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m33a4t5dhg.fsf@intrepid.localdomain>
Date:	Thu, 05 Nov 2009 14:04:59 +0100
From:	Krzysztof Halasa <khc@...waw.pl>
To:	Roel Kluin <roel.kluin@...il.com>
Cc:	Karl Hiramoto <karl@...amoto.org>, Imre Kaloz <kaloz@...nwrt.org>,
	linux-arm-kernel@...ts.infradead.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] IXP4xx: Ensure index is positive

Roel Kluin <roel.kluin@...il.com> writes:

> +++ b/arch/arm/mach-ixp4xx/common.c
> @@ -117,7 +117,7 @@ int gpio_to_irq(int gpio)
>  }
>  EXPORT_SYMBOL(gpio_to_irq);
>  
> -int irq_to_gpio(int irq)
> +int irq_to_gpio(unsigned int irq)
>  {
>  	int gpio = (irq < 32) ? irq2gpio[irq] : -EINVAL;
>  
> diff --git a/arch/arm/mach-ixp4xx/include/mach/gpio.h b/arch/arm/mach-ixp4xx/include/mach/gpio.h
> index cd5aec2..a5f87de 100644
> --- a/arch/arm/mach-ixp4xx/include/mach/gpio.h
> +++ b/arch/arm/mach-ixp4xx/include/mach/gpio.h
> @@ -70,7 +70,7 @@ static inline void gpio_set_value(unsigned gpio, int value)
>  #include <asm-generic/gpio.h>			/* cansleep wrappers */
>  
>  extern int gpio_to_irq(int gpio);
> -extern int irq_to_gpio(int gpio);
> +extern int irq_to_gpio(unsigned int irq);
>  
>  #endif
>  
> diff --git a/arch/arm/mach-ixp4xx/include/mach/npe.h b/arch/arm/mach-ixp4xx/include/mach/npe.h
> index 37d0511..e320db2 100644
> --- a/arch/arm/mach-ixp4xx/include/mach/npe.h
> +++ b/arch/arm/mach-ixp4xx/include/mach/npe.h
> @@ -33,7 +33,7 @@ int npe_send_message(struct npe *npe, const void *msg, const char *what);
>  int npe_recv_message(struct npe *npe, void *msg, const char *what);
>  int npe_send_recv_message(struct npe *npe, void *msg, const char *what);
>  int npe_load_firmware(struct npe *npe, const char *name, struct device *dev);
> -struct npe *npe_request(int id);
> +struct npe *npe_request(unsigned id);
>  void npe_release(struct npe *npe);
>  
>  #endif /* __IXP4XX_NPE_H */
> diff --git a/arch/arm/mach-ixp4xx/ixp4xx_npe.c b/arch/arm/mach-ixp4xx/ixp4xx_npe.c
> index 47ac69c..e8bb257 100644
> --- a/arch/arm/mach-ixp4xx/ixp4xx_npe.c
> +++ b/arch/arm/mach-ixp4xx/ixp4xx_npe.c
> @@ -665,7 +665,7 @@ err:
>  }
>  
>  
> -struct npe *npe_request(int id)
> +struct npe *npe_request(unsigned id)

It looks good, thanks a lot.
-- 
Krzysztof Halasa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/