linux-kernel - Re: [PATCH 06/41] rt2800pci: fix comment about IV/EIV fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200911051941.53838.IvDoorn@gmail.com>
Date:	Thu, 5 Nov 2009 19:41:53 +0100
From:	Ivo van Doorn <ivdoorn@...il.com>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc:	linux-wireless@...r.kernel.org,
	Gertjan van Wingerde <gwingerde@...il.com>,
	linux-kernel@...r.kernel.org,
	"John W. Linville" <linville@...driver.com>
Subject: Re: [PATCH 06/41] rt2800pci: fix comment about IV/EIV fields

On Wednesday 04 November 2009, Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
> Subject: [PATCH] rt2800pci: fix comment about IV/EIV fields
> 
> The bit tested by hardware is TXD_W3_WIV and its value
> equals the negated value of ENTRY_TXD_ENCRYPT_IV bit.
> 
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>

Acked-by: Ivo van Doorn <IvDoorn@...il.com>

> ---
>  drivers/net/wireless/rt2x00/rt2800pci.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Index: b/drivers/net/wireless/rt2x00/rt2800pci.c
> ===================================================================
> --- a/drivers/net/wireless/rt2x00/rt2800pci.c
> +++ b/drivers/net/wireless/rt2x00/rt2800pci.c
> @@ -2206,8 +2206,8 @@ static void rt2800pci_write_tx_desc(stru
>  
>  	/*
>  	 * Always write 0 to IV/EIV fields, hardware will insert the IV
> -	 * from the IVEIV register when ENTRY_TXD_ENCRYPT_IV is set to 0.
> -	 * When ENTRY_TXD_ENCRYPT_IV is set to 1 it will use the IV data
> +	 * from the IVEIV register when TXD_W3_WIV is set to 0.
> +	 * When TXD_W3_WIV is set to 1 it will use the IV data
>  	 * from the descriptor. The TXWI_W1_WIRELESS_CLI_ID indicates which
>  	 * crypto entry in the registers should be used to encrypt the frame.
>  	 */
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/