lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 5 Nov 2009 13:44:45 +0900 From: FUJITA Tomonori <fujita.tomonori@....ntt.co.jp> To: mingo@...e.hu Cc: tj@...nel.org, joerg.roedel@....com, jbarnes@...tuousgeek.org, dwmw2@...radead.org, fujita.tomonori@....ntt.co.jp, x86@...nel.org, tglx@...utronix.de, hpa@...or.com, athena@...w.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] x86: fix iommu=nodac parameter handling On Wed, 4 Nov 2009 13:28:27 +0100 Ingo Molnar <mingo@...e.hu> wrote: > > * Tejun Heo <tj@...nel.org> wrote: > > > nodac should forbid dac instead of enabling it. Fix it. > > > > Signed-off-by: Tejun Heo <tj@...nel.org> > > Cc: Matteo Frigo <athena@...w.org> > > Cc: stable@...nel.org > > --- > > This was posted several months ago in a two patch series. The second > > one was rejected by Alan and with that the first one got lost too > > although it's an apparent bug fix. Matteo hit this bug recently and > > reminded me about this patch. So, regenerated and reposting. > > > > Thanks. > > > > arch/x86/kernel/pci-dma.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/x86/kernel/pci-dma.c b/arch/x86/kernel/pci-dma.c > > index d20009b..8cf3996 100644 > > --- a/arch/x86/kernel/pci-dma.c > > +++ b/arch/x86/kernel/pci-dma.c > > @@ -216,7 +216,7 @@ static __init int iommu_setup(char *p) > > if (!strncmp(p, "allowdac", 8)) > > forbid_dac = 0; > > if (!strncmp(p, "nodac", 5)) > > - forbid_dac = -1; > > + forbid_dac = 1; > > if (!strncmp(p, "usedac", 6)) { > > forbid_dac = -1; > > return 1; > > (Cc:-ed more interested parties.) Looks fine to me. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists