linux-kernel - [PATCH] slqb: A not quite so trivial warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091106112942.14595.29799.stgit@localhost.localdomain>
Date:	Fri, 06 Nov 2009 11:29:57 +0000
From:	Alan Cox <alan@...ux.intel.com>
To:	mel@....ul.fi, penberg@...helsinki.fi, linux-kernel@...r.kernel.org
Subject: [PATCH] slqb: A not quite so trivial warning

mm/slqb.c:2773: warning: initialization from incompatible pointer type

Variable scope...

Signed-off-by: Alan Cox <alan@...ux.intel.com>
---

 mm/slqb.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)


diff --git a/mm/slqb.c b/mm/slqb.c
index e745d9a..fddcf85 100644
--- a/mm/slqb.c
+++ b/mm/slqb.c
@@ -2770,16 +2770,16 @@ static DEFINE_PER_CPU(struct delayed_work, cache_trim_work);
 
 static void __cpuinit start_cpu_timer(int cpu)
 {
-	struct delayed_work *cache_trim_work = &per_cpu(cache_trim_work, cpu);
+	struct delayed_work *lcache_trim_work = &per_cpu(cache_trim_work, cpu);
 
 	/*
 	 * When this gets called from do_initcalls via cpucache_init(),
 	 * init_workqueues() has already run, so keventd will be setup
 	 * at that time.
 	 */
-	if (keventd_up() && cache_trim_work->work.func == NULL) {
-		INIT_DELAYED_WORK(cache_trim_work, cache_trim_worker);
-		schedule_delayed_work_on(cpu, cache_trim_work,
+	if (keventd_up() && lcache_trim_work->work.func == NULL) {
+		INIT_DELAYED_WORK(lcache_trim_work, cache_trim_worker);
+		schedule_delayed_work_on(cpu, lcache_trim_work,
 					__round_jiffies_relative(HZ, cpu));
 	}
 }

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/