[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <200911061924.52696.IvDoorn@gmail.com>
Date: Fri, 6 Nov 2009 19:24:52 +0100
From: Ivo van Doorn <ivdoorn@...il.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc: linux-wireless@...r.kernel.org,
Gertjan van Wingerde <gwingerde@...il.com>,
linux-kernel@...r.kernel.org,
"John W. Linville" <linville@...driver.com>
Subject: Re: [PATCH 35/41] rt2800: prepare for rt2800lib addition
Hi,
> @@ -2644,6 +2658,8 @@ static int rt2800usb_probe_hw(struct rt2
> {
> int retval;
>
> + rt2x00_set_chip_intf(rt2x00dev, RT2X00_CHIP_INTF_USB);
> +
> rt2x00dev->priv = (void *)&rt2800usb_rt2800_ops;
>
> /*
>
Another afterthought, so perhaps you could make it an incremental patch.
Could you move the rt2x00_set_chip_intf() to rt2x00pci and rt2x00usb?
That way the field will be set automatically for all drivers early during probe.
Thanks,
Ivo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists