linux-kernel - Re: [PATCH] Please get this committed, _NOW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 8 Nov 2009 23:11:53 +0800
From:	Américo Wang <xiyou.wangcong@...il.com>
To:	Andreas Mohr <andi@...as.de>
Cc:	Américo Wang <xiyou.wangcong@...il.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	"Michael A. Griffith" <grif@....org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Please get this committed, _NOW_ (preferrably 5 years
	ago), thanks.

On Sun, Nov 08, 2009 at 03:45:50PM +0100, Andreas Mohr wrote:
>Hi,
>
>On Sun, Nov 08, 2009 at 10:25:06PM +0800, Américo Wang wrote:
>> On Sun, Nov 08, 2009 at 01:00:08PM +0100, Andreas Mohr wrote:
>> >--- linux-2.6.32-rc6/init/main.c.orig	2009-11-08 11:09:51.000000000 +0100
>> >+++ linux-2.6.32-rc6/init/main.c	2009-11-08 12:40:11.000000000 +0100
>> >@@ -846,7 +846,47 @@ static noinline int init_post(void)
>> > 	run_init_process("/bin/init");
>> > 	run_init_process("/bin/sh");
>> > 
>> >-	panic("No init found.  Try passing init= option to kernel.");
>> >+	panic("No init found.  Try passing init= option to kernel. "
>> >+    y          "See Linux " __FILE__ " for guidance.");
>> 
>> 
>> I would like to put those guidelines in a doc file, instead
>> of being a FAT comment in the source code.
>
>Heh, somehow I fully expected this objection to come up ;)
>(and you're probably right after all)
>
>So, where to put it?
>Documentation/initrd.txt is related, however I'd create something
>like Documentation/initialization/...
>Or perhaps Documentation/bootup/init.txt ?

Personally, I prefer Documentation/init.txt, but adding it to
initrd.txt also makes sense for me. :)

>
>> And, you're explaining the _user space_ reasons that causes
>> this problem, not related with kernel at all.
>
>That's usually within the responsibility of the one passing control,
>not the one gaining control.
>Just like with children, where it's firmly the parents' job to take care
>of getting their children safely to kindergarden, not the kindergarden's ;)
>
>Plus in my case it _was_ a kernel issue (problematic/non-working serial
>console device). And except for the linker issues of missing libraries,
>many issues (USB functionality etc.) were kernel-related, too.

Yeah, I mentioned it to mean it is not suitable to explain
user-space problems in a kernel source file. Putting it into a kernel
doc should be fine.

Thanks.


-- 
Live like a child, think like the god.
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/